Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

Commit 584a34a

Browse files
authored
fix(agent): hide effort controls for Kimi sessions (#3935)
1 parent 0227c99 commit 584a34a

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

‎packages/agent/src/adapters/claude/claude-agent.resume-model.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ function getModelConfigOption(response: {
8484
return response.configOptions?.find((opt) => opt.id === "model");
8585
}
8686

87+
function getEffortConfigOption(response: {
88+
configOptions?: Array<{ id: string; currentValue?: unknown }> | null;
89+
}) {
90+
return response.configOptions?.find((opt) => opt.id === "effort");
91+
}
92+
8793
// Real temp dirs: createSession validates cwd and SettingsManager reads
8894
// settings from disk; CLAUDE_CONFIG_DIR keeps both away from the real home.
8995
const cwd = mkdtempSync(path.join(os.tmpdir(), "claude-agent-test-cwd-"));
@@ -358,6 +364,21 @@ describe("ClaudeAcpAgent session creation", () => {
358364
}
359365
});
360366

367+
it("does not expose effort controls when a new session starts with Kimi K3", async () => {
368+
const agent = makeAgent();
369+
370+
const response = await agent.newSession({
371+
cwd,
372+
mcpServers: [],
373+
_meta: { taskRunId: "run-kimi", model: "moonshotai/kimi-k3" },
374+
});
375+
376+
expect(getModelConfigOption(response)?.currentValue).toBe(
377+
"moonshotai/kimi-k3",
378+
);
379+
expect(getEffortConfigOption(response)).toBeUndefined();
380+
});
381+
361382
// The timeout *message* (RequestError "... timed out after ...") is covered
362383
// by claude-agent.refresh.test.ts. Here we cover the leak fix on the
363384
// new-session and resume paths: any init failure must close the query so the

‎packages/agent/src/adapters/claude/claude-agent.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2252,6 +2252,7 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
22522252
settingsManager.getSettings().model,
22532253
meta?.model,
22542254
]);
2255+
modelOptions.currentModelId = resolvedModelId;
22552256
session.modelId = resolvedModelId;
22562257
session.lastContextWindowSize =
22572258
this.getContextWindowForModel(resolvedModelId);

0 commit comments

Comments
 (0)