Skip to content

Added rescueWithdrawalNFT functions to Lido and EtherFi Adapters#237

Draft
naddison36 wants to merge 1 commit into
nicka/withdraw-on-swapfrom
nicka/recover-nft
Draft

Added rescueWithdrawalNFT functions to Lido and EtherFi Adapters#237
naddison36 wants to merge 1 commit into
nicka/withdraw-on-swapfrom
nicka/recover-nft

Conversation

@naddison36
Copy link
Copy Markdown
Collaborator

Changes

  • Added rescueWithdrawalNFT(requestId, to) to:
    • AbstractLidoAssetAdapter
    • EtherFiAssetAdapter
    • WeETHAssetAdapter
  • Rescue is restricted to the ARM owner.
  • Rescue reverts for active adapter-managed withdrawal NFTs:
    • Lido checks requestShares[requestId] and requestAssets[requestId]
    • EtherFi checks requestShares[requestId]
  • Added custom errors:
    • ActiveWithdrawalNFT(uint256 requestId)
    • OnlyARMOwner()
  • Added IOwnable interface for adapter-side ARM owner checks.
  • Added fork test coverage for:
    • rescuing untracked withdrawal NFTs
    • preventing rescue of active adapter-managed NFTs
    • rejecting non-owner rescue attempts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant