hackEarlySend is incompatible with Cardboard

[jakobkmar]

Enabling hackEarlySend - because I am using LuckPerms - causes all players to connect as "offline" players.

(When hackEarlySend is set to false (only possible without LuckPerms) everyone is in normal online mode as usual, this is why I think that enabling hackEarlySend is the cause.)

Am I overseeing something here, or is this a bug?

The config:

hackOnlineMode = true
hackEarlySend = true
secret = "secret"

[jakobkmar]

Update: The hackEarlySend feature seems to be incompatible with Cardboard.

[jakobkmar]

For a fix, you might have a look at these Mixins from Cardboard:

ServerLoginNetworkHandler (the class where the mixin for hackEarlySend is applied) is also modified by cardboard:
https://github.com/CardboardPowered/cardboard/blob/master/src/main/java/org/cardboardpowered/mixin/network/MixinServerLoginNetworkHandler.java

and possibly any of these other network mixins are related aswell:
https://github.com/CardboardPowered/cardboard/tree/master/src/main/java/org/cardboardpowered/mixin/network

[jakobkmar]

Even more specific: I think this mixin causes the issue.

Is it possible to fix this incompatibility? (Or is this maybe an issue which has to be fixed by Cardboard?)

[james58899]

Even more specific: I think this mixin causes the issue.

Is it possible to fix this incompatibility? (Or is this maybe an issue which has to be fixed by Cardboard?)

Yes it need fixed by Cardboard, it skip FabricProxy auth process.
I think this mixin is not necessary, maybe Cardboard can add config to allow disable it.

[jakobkmar]

cardboard issue:
CardboardPowered/cardboard#209

[jakobkmar]

Mh just a guess: Couldn't you remove this cancel call, and then I will create a PR to Cardboard to execute cardboards logic AFTER the logic of FabricProxy-Lite (only possible if FabricProxy-Lite does not cancel immediately)?