Top Bar new features (groups, sections and more)#149
Open
ArthurYdalgo wants to merge 22 commits into
Open
Conversation
Author
|
I can add a PR in the nativephp.com repo for the documentation as well, if this is eventually merged |
- top bar section - action role (destructive only) - action subtitle
removal of weird empty space in case section title is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements some features to the EDGE Components:
<native:top-bar-group /><native:top-bar-section /><native:top-bar-action />receives two new props:subtitle="..."role="..."(iOS only)iOS compatibility
I tried to make it work on iOS 18 and previous, but I wasn't successful. This might be an impediment, although given the percentage of users already on iOS 26 this might be an acceptable (or not) compromise.
EDGE Components
Top Bar Group
This component groups
<native:top-bar-actions />and/or<native:top-bar-section />together in a collapsible menu (kind of similar to the auto-collapse that already happens when there're too many actions on the top bar).It has the following props:
<native:top-bar-action />or<native:top-bar-section />Top Bar Section
This component creates a section inside a tab-group, in case you want to keep things more organized.
It has one single prop called
title, which must be declared, but it can be an empty string so it won't show anythingTop Bar Action (new props)
The following props were added to a
<native:top-bar-action />:destructivevalue to make the text red, to indicate a destructive action.Usage example
iOS 26 simulator
first-test-compressed.mp4
Android 15 device (Galaxy S22+)
Screen_Recording_20260602_020733.mp4
Does auto-collapse still work?
Yes...
iOS 26 simulator
second-test-compressed.mp4
Android 15 device (Galaxy S22+)
Screen_Recording_20260602_022418.mp4
Test plan
vendor/bin/pest)I did try to use Jump to test on a real iOS device, but it didn't work. I assume it's because the swift changes I did are not reflected on the device.
Test Repo
I've tested these changes on a
laravel new ...project with react and inertia: https://github.com/ArthurYdalgo/laravel-nativeLLM Usage Disclosure
This code was implemented using GPT-5.2-Codex (Medium effort) and Gemini 3.1 Pro (Medium effort)