[https://nvbugs/6086538][fix] suppress misleading skip-softmax FMHA warning in generation#13157
Conversation
… generation Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
📝 WalkthroughWalkthroughA configuration flag Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #44187 [ run ] triggered by Bot. Commit: |
|
PR_Github #44187 [ run ] completed with state
|
|
/bot run --disable-fail-fast --reuse-test |
|
PR_Github #44210 [ run ] triggered by Bot. Commit: |
|
PR_Github #44210 [ run ] completed with state
|
|
/bot run --disable-fail-fast --reuse-test |
|
PR_Github #44277 [ run ] triggered by Bot. Commit: |
|
PR_Github #44277 [ run ] completed with state
|
|
/bot run --disable-fail-fast --reuse-test |
|
PR_Github #44295 [ run ] triggered by Bot. Commit: |
|
PR_Github #44295 [ run ] completed with state
|
|
/bot run --disable-fail-fast --reuse-test |
|
PR_Github #44416 [ run ] triggered by Bot. Commit: |
|
PR_Github #44416 [ run ] completed with state |
Summary
Suppress the FMHA "Consider using numInstsQ = 2" INFO log for skip-softmax generation kernels.
The warning is misleading for this path because skip-softmax generation intentionally uses a 1x1 numInsts configuration, while the existing INFO suggests 2x1 would be preferable.
Validation
build_wheel_targetssuccessfullySummary by CodeRabbit