Use of native code?

[lsd-cat]

First of all, thanks for the great project, you wrote and maintained so much code and it works pretty well.

I'm using your library in another open source app, and I'm trying to keep dependencies to the minimum and also reduce native code as much as possible, given also that in F-Droid distributions it has to be bundled for all architectures in the same file. I see you developed spake2-java, which afaik is the only Java implementation, but then the package in maven has both the compiled c++ version and the pure java one. Could libadb-android work with the pure Java one only?

Following that, it is my understanding that Android 11+ ship a usable system Conscrypt. I did a brief attempt at adding a org.conscrypt class that bridges the system one, removing the external deps and the need for hidden API bypass, and it seemed to work on Android 15/16, but it seemed to fail on Android 11. Do you think libadb-android could work with the system Conscrypt and without hidden API bypass if the targets were all Android 11+?

If the answers are positive, I'm happy to contribute code back here so that libadb can fall back nicely on the system Conscrypt when possible!

[lsd-cat]

I re-read the documentation and understand better the choice between external Conscrypt and the HiddenApiBypass :( it seems like either way it's gonna be really hard to get rid of NDK pieces. I also tried to force the java spake2, but it seems to fail at pairing:

2025-09-23 23:33:37.278  4223-4223  AdbManager              org.lsd.myapp      D  Start pairing service...
2025-09-23 23:33:37.484  4223-4263  org.lsd.myapp           org.lsd.myapp      I  oneway function results will be dropped but finished with status UNKNOWN_TRANSACTION and parcel size 0
2025-09-23 23:33:44.382  4223-5580  AdbPairingService       org.lsd.myapp      I  Pairing service port: 46483
2025-09-23 23:33:50.628  4223-5727  System.out              org.lsd.myapp      I  Using default TLSv1.3 provider...
2025-09-23 23:33:50.649  4223-5727  m                       org.lsd.myapp      D  Handshake succeeded.
2025-09-23 23:33:50.689  4223-4239  nessuno.bugban          org.lsd.myapp      I  Background young concurrent copying GC freed 75489(2777KB) AllocSpace objects, 0(0B) LOS objects, 17% free, 5236KB/6385KB, paused 6.769ms total 34.692ms
2025-09-23 23:33:50.693  4223-5727  System.out              org.lsd.myapp      I  PVKEY(Alice): e5847bb590f93e532557767828824cab7f746e898c187ccedc12a9b58884394aed9d5de91973a0ef6f01f6a43b2b5c18b7ba61705a3ae8a0a3fd7572b9704f1e
2025-09-23 23:33:50.700  4223-5727  System.out              org.lsd.myapp      I  Q*(Alice): fd80589eaaed8b0b0d727b507d402e42e6bf242348d1443cc08c55322d4cbe62
2025-09-23 23:33:50.702  4223-5727  System.out              org.lsd.myapp      I  PEER'S MASK(Alice): 600bc30f74a0fff7f8a0e7a0f4e7ac702060e838f72a7e80079412a6759edb97
2025-09-23 23:33:50.702  4223-5727  System.out              org.lsd.myapp      I  ===> 34147992 48315982 2281666 36039158 6363658 62646804 94832602 58911192 78804850 36577248 
2025-09-23 23:33:50.720  4223-5727  System.out              org.lsd.myapp      I  QExt(Alice): 98ca02fb8c6947d4426351614ab1c03391d6f9978b287fdda376a6cca53ba60b
2025-09-23 23:33:50.720  4223-5727  System.out              org.lsd.myapp      I  DH(Alice): 3839b477f14fd93e43e4cbd54a23bd554daed46f9f46015cba178a77af9da09a
2025-09-23 23:33:50.728  4223-5727  m                       org.lsd.myapp      E  Unsupported payload while decrypting peer info.
2025-09-23 23:33:50.728  4223-5727  AdbPairingService       org.lsd.myapp      W  pair failed
                                                                                                    java.io.IOException: Could not exchange peer info.

The way I forced the Java version was to add to my gradle build file:

configurations.all {

    resolutionStrategy.dependencySubstitution {
        substitute(module("com.github.MuntashirAkon.spake2-java:android"))
            .using(module("com.github.MuntashirAkon.spake2-java:java:2.0.0"))
    }
}

[MuntashirAkon]

Unfortunately, the Java version doesn't have full support for SPAKE2 unlike the C version.

[ignoramous]

given also that in F-Droid distributions it has to be bundled for all architectures in the same file

This isn't true, F-Droid does vend split APKs (ref: celzero/rethink-app#47).

[lsd-cat]

Thanks for looking into this, and thanks @ignoramous I coudn't find any F-droid specific doc, and so I assumed it wasn't supported. Will look into existing working ones and aim for something similar!