From c9e202bff4bb5da04a4fc438f6e21044d5e188ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Esteban=20Zim=C3=A1nyi?= Date: Tue, 1 Sep 2026 02:42:16 +0200 Subject: [PATCH] Refuse a skip, and a suite that shrank MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The build's own summary states two things this job's conclusion does not. A test reported SKIPPED asserts nothing while the job still reads success — one flag is enough to reach it, and MobilityFlink's binding module under `-Dmeos.enabled=false` reports `Tests run: 7, Failures: 0, Errors: 0, Skipped: 7` beside `BUILD SUCCESS`, its whole MEOS surface disabled under a green build. A test the run never collects is worse, because it appears in no count at all: a surefire ``, a `-Dtest=` filter, a class renamed out of `*Test` or a deleted file all leave the skip number at zero. Once skipping is refused, removing a test is the remaining way to stop running it, so the total carries a floor. The rules live in MEOS-API beside the catalog and the tree-hygiene check, so this repository carries no copy of them. The build is teed to a log under `set -o pipefail`, so `tee` cannot mask a failing build, and the check reads the summary from it. --- .github/workflows/maven.yml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 3bf9853..a323ee6 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -85,4 +85,18 @@ jobs: - name: Test the Kafka Streams app # The generated MeosOps* facades forward to the installed JMEOS jar; the tests exercise # them against libmeos from /usr/local/lib (surefire sets LD_LIBRARY_PATH=meos.lib.dir). - run: mvn -B clean test + run: | + set -o pipefail + mvn -B clean test | tee "$RUNNER_TEMP/build.log" + + # The build's own summary states two things this job's conclusion does + # not: a test reported SKIPPED asserts nothing while the job still reads + # success, and a test the run never collects appears in no count at all, + # so removing one leaves the skip number at zero. The floor is what + # guards the second. Raise it when the suite grows; lowering it belongs + # in the commit that accounts for the removal. + - name: Refuse a skip, and a suite that shrank + uses: MobilityDB/MEOS-API/.github/actions/check-test-outcome@master + with: + log: ${{ runner.temp }}/build.log + min-tests: "11"