Skip to content

New Kaitai-based NVRAM parsers can't split "this doesn't look like a valid item at all" from "this item looks promising, but has parsing errors" #415

Description

@NikolajSchlej

Previous hand-crafted NVRAM parsers could be used as a diagnostic tool and they've tolerated some minor parsing issues and were vocal about them.

Kaitai-based parsers are all much stricter and like to throw a lot of exceptions of various usefulness about where exactly the issue happens. However, all such issues are fatal to further parsing, and we aren't attempting to catch them one by one and inform the user about it, we just proceed like nothing happened, and a potentially corrupted NVRAM area is just silently detected as Padding.

@vit9696 correctly indicated this behavior to be suboptimal, and I might need to return to fixing it in the future.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions