From 8f3cbc77043b16a30f6a61daabf26008dd1640c7 Mon Sep 17 00:00:00 2001
From: Prometheus <prometheus@aucamp.house>
Date: Wed, 26 Aug 2026 14:30:27 +0200
Subject: [PATCH] =?UTF-8?q?fix(mem0):=20recreate=20backend=20on=20closed-c?=
 =?UTF-8?q?lient=20sync=20failure=20(#FILED=20issue=20:=20[FIX]=20mem0=20m?=
 =?UTF-8?q?emory=20sync=20failing:=20'NoneType'=20object=20has=20no=20attr?=
 =?UTF-8?q?ibute=20'save=5Fmessages'=20/=20closed=20client=20=E2=80=94=20m?=
 =?UTF-8?q?emory=20writes=20silently=20dropped)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 plugins/memory/mem0/__init__.py | 46 ++++++++++++++++++++++++++++++---
 1 file changed, 42 insertions(+), 4 deletions(-)

diff --git a/plugins/memory/mem0/__init__.py b/plugins/memory/mem0/__init__.py
index ac823337d0..9f176198e4 100644
--- a/plugins/memory/mem0/__init__.py
+++ b/plugins/memory/mem0/__init__.py
@@ -316,6 +316,7 @@ def __init__(self):
         self._breaker_open_until = 0.0
         self._breaker_lock = threading.Lock()
         self._sync_lock = threading.Lock()
+        self._sync_failures = 0  # consecutive sync failures (#117) — health signal
         self._prefetch_lock = threading.Lock()
         self._atexit_registered = False
 
@@ -584,14 +585,21 @@ def sync_turn(self, user_content: str, assistant_content: str, *, session_id: st
             return
 
         def _sync():
+            # #117 recreate-on-failure: a closed/None SDK client (after atexit
+            # shutdown, a backend restart, or a stalled Qdrant connection)
+            # poisons every subsequent sync with "'NoneType' object has no
+            # attribute 'save_messages'" / "client has been closed". Detect the
+            # failure, rebuild the backend once, and retry a single time before
+            # surfacing — then expose the failure count as a health signal so
+            # silent memory-write loss never goes unnoticed.
             backend = self._backend
             if backend is None:
                 return
+            messages = [
+                {"role": "user", "content": user_content},
+                {"role": "assistant", "content": assistant_content},
+            ]
             try:
-                messages = [
-                    {"role": "user", "content": user_content},
-                    {"role": "assistant", "content": assistant_content},
-                ]
                 backend.add(
                     messages,
                     user_id=self._user_id,
@@ -600,9 +608,39 @@ def _sync():
                     metadata=self._write_metadata(),
                 )
                 self._record_success()
+                self._sync_failures = 0
             except Exception as e:
                 self._record_failure()
+                self._sync_failures += 1
                 logger.warning("Mem0 sync failed: %s", e)
+                if self._sync_failures <= 1:
+                    try:
+                        rebuilt = self._create_backend()
+                    except Exception:
+                        rebuilt = None
+                    if rebuilt is not None:
+                        self._backend = rebuilt
+                        try:
+                            self._backend.add(
+                                messages,
+                                user_id=self._user_id,
+                                agent_id=self._agent_id,
+                                infer=True,
+                                metadata=self._write_metadata(),
+                            )
+                            self._record_success()
+                            self._sync_failures = 0
+                            return
+                        except Exception as e2:
+                            self._record_failure()
+                            logger.warning(
+                                "Mem0 sync retry after backend rebuild failed: %s", e2
+                            )
+                logger.error(
+                    "Mem0 sync FAILED %d consecutive time(s) — memory writes are "
+                    "being dropped (health signal mem0_sync_failures=%d)",
+                    self._sync_failures, self._sync_failures,
+                )
 
         with self._sync_lock:
             if self._sync_thread and self._sync_thread.is_alive():