From b80ab834fbdf1859f329903c69a67a2fd7d9beae Mon Sep 17 00:00:00 2001 From: Guilherme Moreira Rodrigues Date: Fri, 24 Jul 2026 18:50:47 -0300 Subject: [PATCH] feat(common): default serviceDiscovery to internal view + tls-skip-verify Make the platform-standard SD defaults the built-in defaults of serviceDiscovery.env so environments do not have to set them per-env: - SD_PREFER_VIEW default external -> internal (in-cluster consumers prefer the internal K8s DNS view) - SD_TLS_SKIP_VERIFY default false -> true Only affects the fallback when global.serviceDiscovery does not set the field; environments that set it explicitly (e.g. benedita) are unchanged. No merged consumer of serviceDiscovery.env yet, so no render regression. --- charts/lerian-common/templates/_service_discovery.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/lerian-common/templates/_service_discovery.tpl b/charts/lerian-common/templates/_service_discovery.tpl index 48d500677..fec2a7cb7 100644 --- a/charts/lerian-common/templates/_service_discovery.tpl +++ b/charts/lerian-common/templates/_service_discovery.tpl @@ -53,9 +53,9 @@ global.serviceDiscovery (all optional except address when enabled): would produce a duplicate key. This helper only adds the derived siblings. */ -}} SD_ADDRESS: {{ $sd.address | quote }} SD_TLS: {{ $sd.tls | default false | quote }} -SD_TLS_SKIP_VERIFY: {{ $sd.tlsSkipVerify | default false | quote }} +SD_TLS_SKIP_VERIFY: {{ $sd.tlsSkipVerify | default true | quote }} SD_WORKLOAD: {{ $sd.workload | default "" | quote }} -SD_PREFER_VIEW: {{ $sd.preferView | default "external" | quote }} +SD_PREFER_VIEW: {{ $sd.preferView | default "internal" | quote }} SD_INTERNAL_ADDRESS: {{ include "lerian-common.internalHost" (dict "name" .name "namespace" .namespace) | quote }} SD_INTERNAL_PORT: {{ .port | quote }} SD_INTERNAL_SCHEME: {{ $sd.internalScheme | default "http" | quote }}