Repository navigation
fix(ios): restore panel buttons after leaving pan mode with a panel shown - #140
Merged
Merged
Conversation
…hown While a map panel was on screen, MapTemplate._invalidate() skipped applying buttons entirely, so dismissing the panning interface left the pan-mode header and map buttons behind. Hand the buttons back to the topmost panel instead, keeping the rule that a panel owns the bar/map buttons while it exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@claude please review |
|
Claude finished @g4rb4g3's task in 1m 25s —— View job Review of PR #140
No significant issues found. Checked specifically:
|
Contributor
|
No significant issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapTemplatenow gives the bar and map buttons back to the topmost panel on invalidate, instead of skipping the update. The panel still owns those buttons while it exists.Problem
_invalidate()skipped applying any buttons while a panel existed, so nothing replaced the pan-mode state. Theme changes had the same gap.Test plan
Checklist
yarn lint:auto-playandyarn typecheck:auto-playpass🤖 Generated with Claude Code (Claude Opus 5.5)