Replace atlas4py.Config.from_kwargs with constructor

Author: wdeconinck

src/atlas4py/_atlas4py_Config.cpp

@@ -276,14 +276,13 @@ void atlas4py::bind_Config( nb::module_& m ) {
 
      nb::class_<atlas::util::Config, eckit::LocalConfiguration>( m, "Config" )
         .def( nb::init() )
-        .def_static( "from_kwargs", []( nb::kwargs kwargs ) {
-            atlas::util::Config config;
+        .def( "__init__", []( atlas::util::Config* config, nb::kwargs kwargs ) {
+            new ( config ) atlas::util::Config();
             for( const auto& pair : kwargs ) {
                 const auto key = nb::cast<std::string>(pair.first);
                 const auto& value = pair.second;
-                config_set(config, key, value);
+                config_set(*config, key, value);
             }
-            return config;
         } )
         .def_static( "from_yaml", []( std::string const& yaml ) {
             return atlas::util::Config( eckit::YAMLConfiguration(yaml) );

tests/test_bindings.py

@@ -211,7 +211,7 @@ def test_config_set_python_types():
     assert [dict(d) for d in c["list_of_dicts"]] == [{"a": 1}, {"b": 2}]
 
 def test_config_contains():
-    config = atlas4py.Config.from_kwargs(option1="value1", option2=42)
+    config = atlas4py.Config(option1="value1", option2=42)
     assert "option1" in config
     assert "option2" in config
     assert "option3" not in config
@@ -223,7 +223,7 @@ def test_config_contains():
 
 
 def test_config_mapping_protocol():
-    config = atlas4py.Config.from_kwargs(option1="value1", option2=42, option3=3.14)
+    config = atlas4py.Config(option1="value1", option2=42, option3=3.14)
     # dict() uses keys() + __getitem__
     d = dict(config)
     assert d == {"option1": "value1", "option2": 42, "option3": 3.14}
@@ -244,8 +244,8 @@ def test_config_mapping_errors():
             config["unsupported"] = value
 
 
-def test_config_from_kwargs():
-    config = atlas4py.Config.from_kwargs(option1="value1", option2=42)
+def test_config_constructor_with_kwargs():
+    config = atlas4py.Config(option1="value1", option2=42)
     config["option3"] = 3.14
     assert config["option1"] == "value1"
     assert config["option2"] == 42