Builder: stop re-showing every property panel as a job delivers results (#111)

Opening a finished calculation shows three panels; leaving one open
while its job finishes showed all of them, the viewer buried in
overlays.  The difference was the tell, and it is exactly what was
reported twice.

addPropertyPanel() has two paths.  For a panel that does not exist yet
it creates one and applies defaultShownPanels -- Calculation Summary,
Energies, MOs -- hiding the rest.  For one that already exists it called
pinfo.Show(), unconditionally.

updatePropertyMenus() runs again every time the calculation gains a
property, and a running job gains them one at a time.  So the first pass
created the panels and hid most of them, and every pass after that took
the other branch and re-showed all of them.  Reopening the calculation
later went back through the creation path, which is why it then looked
correct.

The forced show has no caller that needs it.  This function's job is to
make sure the panel exists and has a Property-menu entry; the user
showing or hiding one goes through OnPropertyMenuClick(), which sets the
pane's visibility itself, and the layout-cache caller restores saved
visibility with LoadPaneInfo() immediately afterwards.  Leaving the pane
alone is also what lets a panel the user closed stay closed while a job
is still running, which it previously could not.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFMUNbw2UpRPmgsqviAowb

Author: andy

src/apps/builder/Builder.C

@@ -4624,7 +4624,23 @@ void Builder::addPropertyPanel(PropertyPanel *panel, const string& name)
   // Don't add this panel if it is already being managed
   wxAuiPaneInfo &pinfo = p_mgr.GetPane(panel);
   if (pinfo.IsOk()) {
-    pinfo.Show();
+    //  Deliberately does NOT Show() it.  This used to, which undid the
+    //  defaultShownPanels choice below every time the function ran
+    //  again -- and it runs again on every property the calculation
+    //  gains.  Leave a calculation open while its job finishes and each
+    //  arriving property re-showed every panel already created, so the
+    //  viewer ended up covered in overlays; reopening the same
+    //  calculation afterwards showed only the default three, because
+    //  then the panels were being created rather than re-visited.  That
+    //  is exactly the reported difference (#111).
+    //
+    //  Nothing needs a forced show here.  This function's job is to make
+    //  sure the panel exists and has a Property-menu entry; the user
+    //  showing or hiding one goes through OnPropertyMenuClick(), which
+    //  sets the pane's visibility itself, and the layout-cache path at
+    //  the other caller restores saved visibility with LoadPaneInfo()
+    //  immediately afterwards.  Leaving it alone is what lets a panel
+    //  the user closed stay closed.
   } else {
     wxAuiPaneInfo info = wxAuiPaneInfo();
     info.DefaultPane();