Skip to content

Commit c6e4ea3

Browse files
author
andy
committed
Merge remote-tracking branch 'origin/wip/no-pw-in-url' into wip/rc5
# Conflicts: # docs/claude/wx-viewer/run-state-colours.md
2 parents f896a20 + d1b1557 commit c6e4ea3

91 files changed

Lines changed: 368 additions & 407 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/claude/codereg/a-codes-theory-name-must-not-equal.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ title: "A code's theory NAME must not equal its CATEGORY"
44
area: codereg
55
section: "Pitfalls found more than once (check for siblings)"
66
paths: [".edml"]
7+
issues: []
78
---
89
**A code's theory NAME must not equal its CATEGORY.** `CalcEd::
910
getTheoryName()` reverses `populateTheories()`'s display convention —

‎docs/claude/codereg/a-combo-whose-default-is-a-bare.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ title: "A combo whose default is a bare integer opens BLANK when the list is bui
44
area: codereg
55
section: "Pitfalls found more than once (check for siblings)"
66
paths: ["tests/dialogs"]
7+
issues: []
78
---
89
**A combo whose default is a bare integer opens BLANK when the list is
910
built conditionally.** `wx.Choice.SetSelection()` ignores an

‎docs/claude/codereg/a-desc-entrys-begin-wording-can-silently.md‎

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,18 @@ type: pitfall
33
title: "A `.desc` entry's `Begin` wording can silently stop matching between versions of the same code"
44
area: codereg
55
section: "Pitfalls found more than once (check for siblings)"
6-
paths: [".desc", "Gaussian-16.expt", "gaussian-03.desc", "gaussian-09.desc", "gaussian-16.desc"]
6+
paths: ["scripts/parsers/gaussian-16.desc", "scripts/parsers/gaussian-09.desc", "scripts/parsers/gaussian-03.desc", "scripts/parsers/Gaussian-16.expt", "scripts/eccejobmonitor"]
77
issues: [80]
88
---
99
**A `.desc` entry's `Begin` wording can silently stop matching between
10-
versions of the same code**, not just between different codes.
11-
`gaussian-16.desc`'s `MULLIKEN` entry had `Begin= Mulliken atomic
12-
charges\:`, copied from `gaussian-09.desc`/`gaussian-03.desc` — but
13-
Gaussian 16 actually prints "Mulliken charges:" (no "atomic").
14-
`Gaussian-16.expt` (the full-output post-hoc parser) has no Mulliken
15-
handling of its own, so this property is *only* ever captured live
16-
via `eccejobmonitor` — the mismatched `Begin` regex meant it was
17-
silently never extracted, for every G16 job, ever (#80). Same
18-
no-error/job-completes-normally shape as the other `.desc` bugs
19-
here. Fixed with an alternation (`Mulliken (atomic )?charges\:`)
20-
rather than assuming the new wording fully replaced the old one.
21-
**Caveat that applies to any fix in this family**: because there's
22-
no reparse-from-saved-output path for a live-monitor-only property,
23-
fixing the regex does *not* retroactively recover data for
24-
already-completed jobs parsed under the old pattern — only a fresh
25-
run monitored under the fixed `.desc` will have the property. If a
26-
"we fixed the parser but the old job still shows nothing" report
27-
comes in, check whether the job actually predates the fix before
28-
assuming it didn't work.
10+
versions of the same code**, not just between codes. Gaussian 16 prints
11+
"Mulliken charges:" where 03/09 printed "Mulliken atomic charges:", and
12+
the G16 `MULLIKEN` entry copied from them never matched. `Gaussian-16.expt`
13+
has no Mulliken handling, so the property is captured only live by
14+
`eccejobmonitor`, and it was simply absent for every G16 job. Match both
15+
wordings (`Mulliken (atomic )?charges`) rather than assuming the new one
16+
replaced the old.
17+
18+
A live-monitor-only property has no reparse from saved output: a `.desc`
19+
fix does not recover it for jobs that ran before the fix, only for new
20+
runs. Check a job's date before concluding a fix did not work.

‎docs/claude/codereg/a-desc-entrys-skip-n-counts-the.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ title: "A `.desc` entry's `Skip=N` counts the `Begin`-matching line itself"
44
area: codereg
55
section: "Added from integrating MOPAC (issue #86) — the second code through"
66
paths: [".desc", "scripts/eccejobmonitor"]
7+
issues: [86]
78
---
89
**A `.desc` entry's `Skip=N` counts the `Begin`-matching line itself**,
910
not N lines *after* it (`scripts/eccejobmonitor`'s Begin/Skip/End

‎docs/claude/codereg/a-desc-parse-types-begin-value-is.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ title: "A `.desc` parse-type's `Begin` value is also its hash key, AND its match
44
area: codereg
55
section: "Added from integrating MOPAC (issue #86) — the second code through"
66
paths: [".desc", "scripts/eccejobmonitor"]
7+
issues: [86]
78
---
89
**A `.desc` parse-type's `Begin` value is also its hash key, AND its
910
match priority** — `scripts/eccejobmonitor`'s `PDFileRead()` keys its

‎docs/claude/codereg/a-dialogs-choice-string-must-match-the.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ type: pitfall
33
title: "A dialog's choice string must match the generator's expected string EXACTLY, or selecting it silently emits nothing"
44
area: codereg
55
section: "Pitfalls found more than once (check for siblings)"
6-
paths: ["ged{03,09,16}theory.py", "scripts/codereg/*theory.py"]
6+
paths: ["scripts/codereg/ged03theory.py", "scripts/codereg/ged09theory.py", "scripts/codereg/ged16theory.py", "scripts/codereg/*theory.py"]
7+
issues: []
78
---
89
**A dialog's choice string must match the generator's expected string
910
EXACTLY, or selecting it silently emits nothing.** The

‎docs/claude/codereg/a-hand-edit-is-the-case-the.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ type: rule
33
title: "A hand edit is the case the checker most needs to see and the one it missed"
44
area: codereg
55
section: "The input checker (`scripts/parsers/verifyinput`, #148)"
6+
paths: ["scripts/parsers/verifyinput", "src/apps/calced/InputVerifier.C", "src/apps/calced/CalcEd.C", "tests/verify"]
7+
issues: [148]
68
---
79
**A hand edit is the case the checker most needs to see and the one
810
it missed.** `processEditCompletion()` wrote Final Edit's result

‎docs/claude/codereg/a-row-of-primitives-check-must-be.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ type: rule
33
title: "A \"row of primitives\" check must be anchored"
44
area: codereg
55
section: "The input checker (`scripts/parsers/verifyinput`, #148)"
6+
paths: ["scripts/parsers/verifyinput", "src/apps/calced/InputVerifier.C", "src/apps/calced/CalcEd.C", "tests/verify"]
7+
issues: [148]
68
---
79
**A "row of primitives" check must be anchored.** Counting numbers
810
found anywhere in the line accepts the *next shell's header*

‎docs/claude/codereg/blank-not-green.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
---
22
type: rule
3-
title: "blank, not green"
3+
title: "An empty finding list leaves the checker's lamp blank, not green"
44
area: codereg
55
section: "The input checker (`scripts/parsers/verifyinput`, #148)"
6+
paths: ["scripts/parsers/verifyinput", "src/apps/calced/InputVerifier.C", "src/apps/calced/CalcEd.C", "tests/verify"]
7+
issues: [148]
68
---
79
An empty finding list means *nothing was checked*, and the lamp goes
810
**blank, not green**. A light that cannot distinguish "looked and

‎docs/claude/codereg/calced-used-to-discard-the-input-generators.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ type: pitfall
33
title: "CalcEd used to discard the input generator's error message"
44
area: codereg
55
section: "Pitfalls found more than once (check for siblings)"
6-
paths: ["/dev/null"]
6+
paths: ["src/apps/calced/CalcEd.C"]
7+
issues: []
78
---
89
**CalcEd used to discard the input generator's error message.**
910
`execout()` captures the generator's stdout+stderr into `message`, and

0 commit comments

Comments
 (0)