Skip to content

Commit c18bfd4

Browse files
andyclaude
andcommitted
Gaussian-03/09: same functional-list defects as Gaussian-16
The defects fixed in 08c296f for Gaussian-16 were copy-pasted into the 03 and 09 dialogs too, so both had a garbage entry in the functional dropdown and three or five functionals that silently generated nothing. Both had the same missing commas on the last two entries, so Python implicitly concatenated them and the dropdown really offered "N12SX (range)MN12SX (range)" while both real functionals were unselectable. Both had the same three string mismatches against their own generator: "MO6HF (hybrid)" (letter O for zero), "MPW1PBE (hybrid" (missing paren) and "MPW3PBE (hybrid)" (generator wants MPw3PBE). ged03theory.py additionally offered "BP86 (hybrid)" and "M06L (nonlocal)" where ai.gauss03 expects "BP86 (GGA)" and "M06L (meta-GGA)" -- so two of the most ordinary functionals available generated nothing at all for a Gaussian 03 calculation. All three Gaussian dialogs now agree exactly with their generators: 0 offered-but-unmapped and 0 concatenated entries across ged03 (61 entries), ged09 (64) and ged16 (74). xcFuncDefault is an index into these lists and this change deletes two broken entries as well as appending, so the defaults were checked against the previous revision rather than assumed: ged03 index 0/17 and ged09/ged16 index 3/17 all resolve to the same functional as before. No g03 or g09 binary is installed here, so these are verified as internal consistency -- the dialog now emits strings its own generator maps -- not against those codes' own keyword tables. The keywords themselves are unchanged from what the generators already produced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 08c296f commit c18bfd4

2 files changed

Lines changed: 16 additions & 12 deletions

File tree

‎scripts/codereg/ged03theory.py‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def __init__(self,parent,helpURL=""):
193193
"M06 (hybrid)",
194194
"X3LYP (hybrid)",
195195
"PBE0 (hybrid)",
196-
"BP86 (hybrid)",
196+
"BP86 (GGA)",
197197
"SVWN 5 (local)",
198198
"SVWN 1/RPA (local)",
199199
"BLYP (nonlocal)",
@@ -203,7 +203,7 @@ def __init__(self,parent,helpURL=""):
203203
"HCTH/147 (nonlocal)",
204204
"HCTH/93 (nonlocal)",
205205
"tHCTH (nonlocal)",
206-
"M06L (nonlocal)",
206+
"M06L (meta-GGA)",
207207
"B97D (nonlocal)",
208208
"B97D3 (nonlocal)",
209209
"SOGGA11 (nonlocal)",
@@ -221,8 +221,7 @@ def __init__(self,parent,helpURL=""):
221221
"MPWPW91 (hybrid)",
222222
"MPW1K (hybrid)",
223223
"MPW1LYP (hybrid)",
224-
"MPW1PBE (hybrid",
225-
"MPW3PBE (hybrid)",
224+
"MPW1PBE (hybrid)",
226225
"O3LYP (hybrid)",
227226
"Becke98 (hybrid)",
228227
"Becke97 (1) (hybrid)",
@@ -231,7 +230,6 @@ def __init__(self,parent,helpURL=""):
231230
"Becke Half and Half (hybrid)",
232231
"Becke Half and LYP Half (hybrid)",
233232
"BMK (hybrid)",
234-
"MO6HF (hybrid)",
235233
"M062X (hybrid)",
236234
"APFD (hybrid)",
237235
"APF (hybrid)",
@@ -248,8 +246,12 @@ def __init__(self,parent,helpURL=""):
248246
"CAM-B3LYP (range)",
249247
"HISSbPBE (range)",
250248
"M11 (range)",
251-
"N12SX (range)"
252-
"MN12SX (range)"
249+
"N12SX (range)",
250+
"MN12SX (range)",
251+
# Appended, not inserted: xcFuncDefault below
252+
# is an INDEX into this list.
253+
"M06HF (hybrid)",
254+
"MPw3PBE (hybrid)"
253255
]
254256
xcFuncDefault = 0
255257
if EcceGlobals.ReactionStudyFlag != 0:

‎scripts/codereg/ged09theory.py‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,7 @@ def __init__(self,parent,helpURL=""):
271271
"MPWPW91 (hybrid)",
272272
"MPW1K (hybrid)",
273273
"MPW1LYP (hybrid)",
274-
"MPW1PBE (hybrid",
275-
"MPW3PBE (hybrid)",
274+
"MPW1PBE (hybrid)",
276275
"O3LYP (hybrid)",
277276
"Becke98 (hybrid)",
278277
"Becke97 (1) (hybrid)",
@@ -281,7 +280,6 @@ def __init__(self,parent,helpURL=""):
281280
"Becke Half and Half (hybrid)",
282281
"Becke Half and LYP Half (hybrid)",
283282
"BMK (hybrid)",
284-
"MO6HF (hybrid)",
285283
"M062X (hybrid)",
286284
"APFD (hybrid)",
287285
"APF (hybrid)",
@@ -298,8 +296,12 @@ def __init__(self,parent,helpURL=""):
298296
"CAM-B3LYP (range)",
299297
"HISSbPBE (range)",
300298
"M11 (range)",
301-
"N12SX (range)"
302-
"MN12SX (range)"
299+
"N12SX (range)",
300+
"MN12SX (range)",
301+
# Appended, not inserted: xcFuncDefault below
302+
# is an INDEX into this list.
303+
"M06HF (hybrid)",
304+
"MPw3PBE (hybrid)"
303305
]
304306
xcFuncDefault = 3 #Andy -- changed default from None to PBE0
305307
if EcceGlobals.ReactionStudyFlag != 0:

0 commit comments

Comments
 (0)