Skip to content

Commit ac678b7

Browse files
author
andy
committed
CalcEd: replace Quick Basis Menu's glossy 3D arrow icon with a Unicode chevron
The dropdown-style arrow on "Quick Basis Menu" looked jarringly out of place next to Theory/Runtype (ewxChoice) and Charge/Spin Mult (ewxComboBox), whose dropdown arrows are drawn natively by GTK3. Traced it to 1downarrow.xpm -- a glossy, gradient-shaded orange orb (2000s "Web 2.0 gel button" style icon art), glued onto a plain button via SetBitmap()/SetBitmapPosition(). A prior fix had already replaced a literal trailing "V" character (a pre-Unicode stand-in) with this icon, reasoning that Unicode glyph rendering was unreliable at the time -- not true on the current wx3.2/GTK3 target. Replaced with a real Unicode down-triangle (U+25BC) in the button label instead, which renders with the system font/theme like every other piece of text in the app, rather than a hand-drawn raster asset. Bump version to v8.0.2 for this batch of fixes (Duplicate menu placement, the RCommand freeze/hang fixes across two follow-up rounds, default-to-bash, this icon fix) -- substantial enough to warrant a bump per current versioning guidance (bump for real batches of fixes, not every trivial change; save x.1.0 for the next actual release milestone).
1 parent 6e26b3c commit ac678b7

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

‎data/client/config/Version‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v8.0.1
1+
v8.0.2

‎src/apps/calced/CalcEdGUI.C‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,14 +332,21 @@ void CalcEdGUI::CreateControls()
332332
wxBoxSizer* itemBoxSizer46 = new wxBoxSizer(wxHORIZONTAL);
333333
itemBoxSizer45->Add(itemBoxSizer46, 0, wxALIGN_LEFT, 5);
334334

335-
ewxButton* itemButton47 = new ewxButton( itemFrame1, ID_BUTTON_CALCED_BASIS_QUICK, _("Quick Basis Menu"), wxDefaultPosition, wxDefaultSize, 0 );
336335
// The trailing literal "V" this label used to end with was a plain-text
337336
// stand-in for a dropdown-arrow indicator (predates reliable Unicode
338-
// glyph rendering) -- replaced with the same down-arrow bitmap already
339-
// used elsewhere in the app (e.g. MDPrepGUI's reorder buttons) instead
340-
// of another ad hoc text character.
341-
itemButton47->SetBitmap(ewxBitmap(_T("1downarrow.xpm"), wxBITMAP_TYPE_XPM));
342-
itemButton47->SetBitmapPosition(wxRIGHT);
337+
// glyph rendering). A later fix replaced that with 1downarrow.xpm (a
338+
// glossy, gradient-shaded orange orb -- 2000s "Web 2.0 gel button"
339+
// style icon art, not a flat chevron), reasoning that Unicode glyph
340+
// rendering was unreliable at the time -- but on the current wx3.2/
341+
// GTK3 target that's no longer true, and the mismatch between that
342+
// icon's heavy skeuomorphic styling and the flat native dropdown
343+
// arrows GTK3 draws on every wxChoice/wxComboBox elsewhere on this
344+
// same panel (Theory, Runtype, Charge, Spin Mult) looked exactly as
345+
// out of place as reported. Using a real Unicode down-triangle
346+
// (U+25BC) in the label instead renders with the system font/theme,
347+
// like every other piece of text in the app, instead of a hand-drawn
348+
// raster asset.
349+
ewxButton* itemButton47 = new ewxButton( itemFrame1, ID_BUTTON_CALCED_BASIS_QUICK, _("Quick Basis Menu ▼"), wxDefaultPosition, wxDefaultSize, 0 );
343350
itemBoxSizer46->Add(itemButton47, 0, wxALIGN_CENTER_VERTICAL|wxALL, 5);
344351

345352
ewxCheckBox* itemCheckBox48 = new ewxCheckBox( itemFrame1, ID_CHECKBOX_CALCED_USE_EXPONENTS, _("Use Exponents\n&& Coefficients"), wxDefaultPosition, wxDefaultSize, wxCHK_2STATE );

0 commit comments

Comments
 (0)