Skip to content

Commit a037c01

Browse files
andyclaude
andcommitted
Launcher: default "Use csh/tcsh" to unchecked -- bash confirmed working end-to-end
Confirmed live: both bugs that motivated defaulting this checkbox to checked (the ssh echo-duplication false-positive, and the SIGHUP-on- background-job issue) are fixed and verified against real, longer- running jobs on both niobium and localhost with the box unticked. Flipping the default to bash, matching RefMachine::shell()'s own default. Checkbox itself stays in place as a troubleshooting toggle. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 0f0d99e commit a037c01

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/apps/launcher/WxLauncherGUI.C‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,8 +721,8 @@ void WxLauncherGUI::CreateControls()
721721

722722
ewxCheckBox* itemCheckBoxForceCsh = new ewxCheckBox( itemPanel3, ID_CHECKBOX_WXLAUNCHER_FORCECSH, _("Use csh/tcsh"), wxDefaultPosition, wxDefaultSize, wxCHK_2STATE );
723723
if (ShowToolTips())
724-
itemCheckBoxForceCsh->SetToolTip(_("Force csh/tcsh for this connection instead of the machine's configured shell.\nChecked (default) avoids a known bash-over-ssh bug where job monitoring\ncan falsely report the job as dead. Uncheck only to test/troubleshoot bash."));
725-
itemCheckBoxForceCsh->SetValue(true);
724+
itemCheckBoxForceCsh->SetToolTip(_("Force csh/tcsh for this connection instead of the machine's configured shell (bash).\nBash is confirmed working (both the ssh echo-duplication bug and the\nSIGHUP-on-background-job bug it used to hit are fixed) -- unchecked by\ndefault. Check this only to test/troubleshoot csh/tcsh specifically."));
725+
itemCheckBoxForceCsh->SetValue(false);
726726
itemBoxSizer124->Add(itemCheckBoxForceCsh, 0, wxALIGN_CENTER_VERTICAL|wxALL, 3);
727727

728728
ewxButton* itemButton128 = new ewxButton( itemPanel3, ID_BUTTON_WXLAUNCHER_LAUNCH, _("Launch"), wxDefaultPosition, wxDefaultSize, 0 );

0 commit comments

Comments
 (0)