Skip to content

Commit 8de2e1c

Browse files
andyclaude
andcommitted
tests: look_hidpi clicks benzene atoms; editor_command sets ECCE_HOME
Water's hydrogens are not hit by a pick at their projected centre after viewall (by the SoEvent path as well), so the test now clicks five benzene atoms. UserEditor's Preferences need ECCE_HOME. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFPK14wBcLD1s4dYUowpP4
1 parent b4a8f6f commit 8de2e1c

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎tests/look/hidpi.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
SCENE = """style Ball And Stick
2424
viewall
2525
snap frame
26-
wxpick clicks 1 2 3
26+
wxpick clicks 1 2 3 4 7
2727
"""
2828

2929

@@ -57,7 +57,7 @@ def run(binary, scale, display):
5757
env.pop("FL_FONT_PATH", None)
5858
env.pop("GDK_DPI_SCALE", None)
5959
env["ECCE_REALUSERHOME"] = tempfile.mkdtemp(prefix="hidpi-home")
60-
r = subprocess.run([binary, out, scene, "water"], env=env,
60+
r = subprocess.run([binary, out, scene, "benzene"], env=env,
6161
capture_output=True, text=True, timeout=300)
6262
if r.returncode != 0:
6363
print("viewer-scenes (scale %d) failed:\n%s" % (scale, (r.stdout + r.stderr)[-1500:]))
@@ -76,7 +76,7 @@ def check(scale, out):
7676
if sel.split() != [atom]:
7777
print("FAIL scale %d: clicking atom %s selected [%s]" % (scale, atom, sel.strip()))
7878
ok = False
79-
if len(got) != 3:
79+
if len(got) != 5:
8080
print("FAIL scale %d: %d clicks recorded" % (scale, len(got)))
8181
ok = False
8282
w, h, px = readPpm(os.path.join(out, "frame.ppm"))

‎tests/transport/testEditorCommand.C‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ int main()
6060
setenv("PATH", (bin + ":/usr/bin:/bin").c_str(), 1);
6161
setenv("HOME", home.c_str(), 1);
6262
setenv("ECCE_REALUSERHOME", home.c_str(), 1);
63-
unsetenv("ECCE_HOME");
63+
setenv("ECCE_HOME", tmp.c_str(), 1);
6464
unsetenv("ECCE_TERMINAL");
6565
unsetenv("VISUAL");
6666
unsetenv("EDITOR");
@@ -71,7 +71,8 @@ int main()
7171
unsetenv("ECCE_EDITOR");
7272
#ifdef __APPLE__
7373
same("default editor", UserEditor().getPreferredEditor(), "open -t");
74-
same("default terminal", UserEditor::getTerminal(), "ecce-macos-terminal");
74+
same("default terminal", UserEditor::getTerminal(),
75+
tmp + "/scripts/ecce-macos-terminal");
7576
same("default command", command(f, false), "open|-t|-W|-n|" + file);
7677
#else
7778
same("default editor", UserEditor().getPreferredEditor(), "vi");

0 commit comments

Comments
 (0)