Organizer: fix 4 null-pointer crashes on cold start (#66)

getResource() can legitimately return null when a resource fails to
load (e.g. the data server isn't reachable/ready yet) -- three call
sites dereferenced it unconditionally: WxResourceTreeCtrl::loadChildren(),
CalcMgr::getTypeAndState(), and CalcMgr::onSelectionChange(). A fourth,
different bug in the same chain: CalcMgr::focusOnTree() dereferenced
p_contextPanel, which can still be null when the tree control receives
a real GTK focus-in event during CalcMgr::Create() itself, before
p_contextPanel has been constructed -- same premature-event-during-
construction class as the Gateway/GatewayPrefs layout crashes fixed
earlier this session, just via focus instead of size events.

All four found and fixed one at a time via real, symbol-matched
coredumps from a reliable cold-start repro (data server down,
ecce-organizer bootstraps it, launches Organizer immediately).
Verified: Organizer now survives the full startup sequence cleanly and
shows its real login dialog once the data server is reachable, instead
of crashing before any window appears.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: andy

src/apps/organizer/CalcMgr.C

@@ -2165,6 +2165,15 @@ bool CalcMgr::getTypeAndState(WxResourceTreeItemData * itemData,
 
   if (itemData != 0) {
     Resource * res = itemData->getResource();
+    // getResource() can legitimately return null (e.g. the resource
+    // failed to load because the data server wasn't reachable/ready
+    // yet) -- confirmed via a real core dump hit on every cold start,
+    // in TreeEvtHandler::OnSetFocus() -> onSelectionChange() ->
+    // getFileMenu() -> here, same bug shape as the WxResourceTreeCtrl
+    // fix alongside this one.
+    if (res == 0) {
+      return false;
+    }
     resType = res->getDescriptor();
     if (resType == 0) {
       return false;
@@ -4868,7 +4877,10 @@ void CalcMgr::onSelectionChange(bool selectInTree)
   }
   else {
     itemData = findNode(p_currentSelection[0], false, true);
-    if (itemData && itemData->getResource()->hasAccess()) {
+    // getResource() can legitimately be null (e.g. resource failed to
+    // load) -- confirmed via a real core dump hit on cold start, same
+    // bug shape fixed twice already just above this call chain.
+    if (itemData && itemData->getResource() && itemData->getResource()->hasAccess()) {
       bool isProject = (itemData->getResource()->getContentType() ==
                         ResourceDescriptor::CT_PROJECT);
       bool isCalculation = (itemData->getResource()->getContentType() ==
@@ -4959,7 +4971,15 @@ void CalcMgr::focusOnTree()
 {
   p_focusOnTree = true;
   onSelectionChange(false);
-  p_contextPanel->loseFocus();
+  // p_contextPanel can still be null here -- confirmed via a real core
+  // dump: the tree control can receive a GTK focus-in event (wired to
+  // this via TreeEvtHandler::OnSetFocus()) during CalcMgr::Create()
+  // itself, before p_contextPanel has been constructed yet. Same
+  // premature-event-during-construction bug class as the Gateway/
+  // GatewayPrefs layout crashes fixed earlier this session, just hit
+  // via focus instead of size events.
+  if (p_contextPanel != 0)
+    p_contextPanel->loseFocus();
 }
 
 

src/wxgui/wxtools/WxResourceTreeCtrl.C

@@ -265,7 +265,18 @@ bool WxResourceTreeCtrl::loadChildren(WxResourceTreeItemData * node, bool refres
   timer.start();
 #endif
 
-  vector<Resource *> * children = node->getResource()->getChildren(refresh);
+  // getResource() can legitimately return null -- confirmed via a real
+  // core dump, hit during Organizer's own automatic startup tree-load
+  // (mountEDSIProviders() -> autoOpen() -> findNode() -> here), when the
+  // resource failed to load (e.g. the data server wasn't reachable/ready
+  // yet). Previously dereferenced unconditionally.
+  Resource * resource = node->getResource();
+  if (resource == 0) {
+    p_loadingChildren = false;
+    return false;
+  }
+
+  vector<Resource *> * children = resource->getChildren(refresh);
 
 #ifdef cputimetest
   timer.stop();