ecce-dataserver-start/-stop: resolve apache2 by full path, not bare PATH lookup

Root-caused on beryllium: bin/gateway was failing to launch, showing a
blocking "cannot establish a connection to the ECCE Server" dialog. Traced
it back to ecce-dataserver-start's `apache2 -f ... -k start` invocation,
which relies on `apache2` being on $PATH. Debian only merges /usr/sbin
(where the apache2 binary lives) into PATH for root -- confirmed via
`systemctl --user show-environment` and gnome-session's own
/proc/<pid>/environ that a regular user's desktop-session PATH does not
include it. The command silently failed with exit 127, the per-user data
server on port 8096 never came up, ecce-gateway-start's `|| true` masked
the failure, and gateway only surfaced it downstream as an opaque
connection-refused dialog instead of an actual error from the script
itself.

Resolve apache2 via `command -v`, falling back to /usr/sbin/apache2, and
fail with a clear message if neither exists. Same fix applied to
ecce-dataserver-stop's apache2 -k stop call.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJdPpqvvDFJoF1xRH4hv19

Author: andy

packaging/dataserver/ecce-dataserver-start

@@ -22,6 +22,20 @@ STATEDIR="$ECCE_REALUSERHOME/.ECCE/dataserver"
 DATAROOT="$STATEDIR/htdocs"
 PORT=8096
 
+# Debian only puts /usr/sbin (where the apache2 binary lives) on PATH for
+# root -- a regular user's login/desktop session PATH does not include it
+# (confirmed via `systemctl --user show-environment` and gnome-session's
+# own /proc/<pid>/environ). Relying on bare `apache2` here silently fails
+# with "command not found" for any non-root, non-customized-PATH user,
+# which then surfaces downstream as bin/gateway's opaque "cannot
+# establish a connection to the ECCE Server" dialog instead of an actual
+# error from this script. Resolve a full path instead.
+APACHE2_BIN="$(command -v apache2 2>/dev/null || echo /usr/sbin/apache2)"
+if [ ! -x "$APACHE2_BIN" ]; then
+  echo "ecce-dataserver-start: no apache2 binary found (looked on PATH and at /usr/sbin/apache2) -- install apache2" >&2
+  exit 1
+fi
+
 port_open() {
   (exec 3<>"/dev/tcp/localhost/$1") >/dev/null 2>&1
   status=$?
@@ -81,7 +95,7 @@ sed -e "s|##HTTPDROOT##|$STATEDIR|g" \
     "$CONF_TEMPLATE" > "$STATEDIR/httpd.conf"
 
 echo "ecce-dataserver-start: starting data server on port $PORT..."
-apache2 -f "$STATEDIR/httpd.conf" -k start
+"$APACHE2_BIN" -f "$STATEDIR/httpd.conf" -k start
 i=0
 while [ $i -lt 40 ]; do
   if port_open "$PORT"; then break; fi

packaging/dataserver/ecce-dataserver-stop

@@ -14,8 +14,10 @@ if [ ! -f "$CONF" ]; then
   exit 0
 fi
 
+APACHE2_BIN="$(command -v apache2 2>/dev/null || echo /usr/sbin/apache2)"
+
 if [ -f "$PIDFILE" ] && kill -0 "$(cat "$PIDFILE" 2>/dev/null)" 2>/dev/null; then
-  apache2 -f "$CONF" -k stop
+  "$APACHE2_BIN" -f "$CONF" -k stop
   echo "ecce-dataserver-stop: stopped data server (pid $(cat "$PIDFILE"))"
 else
   echo "ecce-dataserver-stop: data server not running"