Fix the auth dialog freezing under Wayland/XWayland (#120)

Root-caused live via gdb, attached to a genuinely stuck process rather
than guessed from source. The ECCE Authentication dialog would show,
accept pointer clicks (OK/Cancel/Change work), and accept zero
keystrokes -- looking exactly like a focus problem, and it is one, but
not the one already fixed for this issue (a modal parented to the
hidden Gateway frame). p_window was reliably nil (a proper unparented
top-level) on every occurrence, including stuck ones.

Confirmed via live introspection on the stuck process (gdb, calling
into the running GTK/GDK state directly):
- The X server's own focus (`xdotool getwindowfocus`,
  `_NET_ACTIVE_WINDOW`) was on Mutter's internal placeholder window
  (no WM_CLASS, no window type), not the dialog.
- GTK agreed: gtk_window_is_active()/has_toplevel_focus() were both 0.
  But gtk_window_get_focus() returned a real widget -- the dialog's
  own internal focus-widget tracking was correct; only the toplevel
  window's WM-level activation was missing.
- Forcing gtk_window_present() (the correct high-level GTK call) did
  NOT fix it. Forcing gtk_window_present_with_time() with a genuinely
  fresh timestamp from gdk_x11_get_server_time() DID -- is_active
  flipped to 1 immediately.

That isolates the cause: this dialog is shown as the very first UI
action in the process's life, before wx's MainLoop() has started and
before the app has processed any real, user-generated X event. wx's
default Show()/ShowModal() path requests activation with whatever
timestamp GDK has cached at that point (0/stale, this early), and
Mutter's focus-stealing prevention silently declines an activation
request carrying an invalid/stale timestamp -- the window ends up
mapped and input-accepting with nothing actually listening.

Fix: WxDavAuth::prompt() explicitly calls
gtk_window_present_with_time() with a fresh, server-fetched timestamp
before every ShowModal() in its retry loop (a re-prompt after a failed
password is its own fresh Show(), same failure shape). CMakeLists.txt
gains the gtk+-3.0 include/link eccewxgui needs for the direct GTK/GDK
calls, following eccewxplotctrl's existing pkg_check_modules(GTK3)
pattern.

Verified live: the exact close-the-dialog-via-X-then-relaunch sequence
that reliably reproduced the freeze no longer does, across several
repeated attempts.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E4HPD1xaxKpyh9gZ6hsBP2

Author: andy

CMakeLists.txt

@@ -267,6 +267,18 @@ pkg_check_modules(GLIB2 REQUIRED glib-2.0)
 target_include_directories(eccewxgui PRIVATE ${GLIB2_INCLUDE_DIRS})
 target_link_libraries(eccewxgui PRIVATE ${GLIB2_LIBRARIES})
 
+# WxDavAuth.C calls gtk_window_present_with_time()/gdk_x11_get_server_time()
+# directly (#120: Mutter's focus-stealing prevention silently drops the
+# auth dialog's window-manager activation unless it's requested with a
+# fresh, real X server timestamp) -- same gtk+-3.0 need as eccewxplotctrl
+# below, headers AND the library this time since it's a real call, not
+# just the log filter's headers-only use above.
+pkg_check_modules(GTK3 QUIET gtk+-3.0)
+if(GTK3_FOUND)
+  target_include_directories(eccewxgui PRIVATE ${GTK3_INCLUDE_DIRS})
+  target_link_libraries(eccewxgui PRIVATE ${GTK3_LIBRARIES})
+endif()
+
 ecce_library(eccewxguicomm src/wxgui/comm)
 target_compile_definitions(eccewxguicomm PRIVATE ${wxWidgets_DEFINITIONS})
 target_include_directories(eccewxguicomm PRIVATE ${wxWidgets_INCLUDE_DIRS})

src/wxgui/wxdialogs/WxDavAuth.C

@@ -12,9 +12,20 @@
   using std::endl;
 
 #include <sys/utsname.h> // uname
+#include <unistd.h>   // getpid, #120 instrumentation
+#include <cstdio>     // fopen/fprintf, #120 instrumentation
 
 #include <wx/wx.h>
 
+//  #120 fix: see the explicit gtk_window_present_with_time() call in
+//  prompt() below for why this is here.
+#if defined(__WXGTK__)
+extern "C" {
+  #include <gtk/gtk.h>
+  #include <gdk/gdkx.h>
+}
+#endif
+
 #include "util/NotImplementedException.H"
 #include "util/NullPointerException.H"
 #include "util/Ecce.H"
@@ -244,6 +255,27 @@ bool WxDavAuth::prompt(const string& strurl,
      }
      p_prompting = true;
 
+     //  TEMPORARY, #120: which parent this dialog actually gets, and
+     //  whether it's currently mapped -- an unmapped/hidden parent is the
+     //  documented cause of "buttons work, keystrokes don't" under
+     //  Wayland/XWayland. dialogParent() is supposed to hand back NULL
+     //  whenever the (hidden-by-default) Gateway frame would otherwise be
+     //  the parent, so p_window should normally be 0 here; if it's ever
+     //  non-null AND not shown, that's the live bug.
+     {
+       const char *where = getenv("ECCE_DEBUG_AUTHPARENT");
+       if (where != 0) {
+         FILE *log = fopen(where, "a");
+         if (log != 0) {
+           fprintf(log, "AUTHPROMPT pid=%d retryCount=%d newUser=%d "
+             "p_window=%p shown=%d\n", (int)getpid(), retryCount,
+             (int)newUser, (void*)p_window,
+             p_window ? (int)p_window->IsShown() : -1);
+           fclose(log);
+         }
+       }
+     }
+
      WxAuth authDlg(p_window);
 
      if (newUser) {
@@ -261,6 +293,38 @@ bool WxDavAuth::prompt(const string& strurl,
      while (!done) {
        ret = false;
        done = true;
+
+       //  #120: this dialog can be shown as the very first UI action in
+       //  the process's life, before wx's own MainLoop() has ever started
+       //  and before the app has processed any real, user-generated X
+       //  event. wx's default Show()/ShowModal() path asks the window
+       //  manager to activate the window using whatever timestamp GDK
+       //  happens to have cached (0/stale, this early), and Mutter's
+       //  focus-stealing prevention silently declines an activation
+       //  request with an invalid/stale timestamp -- the window is
+       //  mapped, input-accepting, and its GTK-internal focus widget is
+       //  correctly set, but it never actually receives keyboard focus,
+       //  and pointer clicks work while not one keystroke does. Confirmed
+       //  live via gdb: forcing a gtk_window_present_with_time() call
+       //  with a FRESH, server-fetched timestamp
+       //  (gdk_x11_get_server_time(), not GDK_CURRENT_TIME) is what
+       //  actually gets Mutter to grant focus -- plain
+       //  gtk_window_present()/wx's own Show() does not. Repeated on
+       //  every loop iteration, not just the first: a re-prompt after a
+       //  failed password is its own fresh Show() and can lose focus the
+       //  same way.
+#if defined(__WXGTK__)
+       {
+         authDlg.Show(true);
+         GtkWidget *gtkWidget = (GtkWidget*)authDlg.GetHandle();
+         GdkWindow *gdkWindow = gtkWidget ? gtk_widget_get_window(gtkWidget) : NULL;
+         if (gdkWindow != NULL) {
+           guint32 freshTime = gdk_x11_get_server_time(gdkWindow);
+           gtk_window_present_with_time(GTK_WINDOW(gtkWidget), freshTime);
+         }
+       }
+#endif
+
        status = authDlg.ShowModal();
 
        if (status == wxID_OK) {