MSI: install empty directories (the shell needs tmp); report where the uninstall entry lands

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PFPK14wBcLD1s4dYUowpP4

Author: andy

packaging/windows/make-msi.ps1

@@ -19,6 +19,11 @@ $ids = @{}; $nid = 0
 $sb = New-Object System.Text.StringBuilder
 function Esc($s) { [Security.SecurityElement]::Escape($s) }
 function Emit($dir, $indent) {
+  # Empty directories (the shell's tmp) are not installed unless something creates them.
+  if (-not (Get-ChildItem -LiteralPath $dir -Force)) {
+    $script:nid++
+    [void]$sb.AppendLine("$indent<Component Id=`"c$nid`"><CreateFolder /></Component>")
+  }
   foreach ($f in Get-ChildItem -LiteralPath $dir -File) {
     $script:nid++
     [void]$sb.AppendLine("$indent<Component Id=`"c$nid`"><File Id=`"f$nid`" Source=`"$(Esc $f.FullName)`" KeyPath=`"yes`" /></Component>")

tests/windows/msi-test.ps1

@@ -22,6 +22,8 @@ $p = Start-Process msiexec -ArgumentList "/i `"$Msi`" /qn /l*v `"$Out\install.lo
 Check ($p.ExitCode -eq 0) "msiexec /i exit $($p.ExitCode)"
 Check (Test-Path "$inst\bin\organizer.exe") "organizer.exe under $inst"
 Check (Test-Path $lnk) "Start-menu shortcut"
+foreach ($h in "HKCU", "HKLM") { foreach ($k in "Software\Microsoft\Windows\CurrentVersion\Uninstall", "Software\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall") {
+  Get-ItemProperty "${h}:\$k\*" -ErrorAction SilentlyContinue | Where-Object { $_.DisplayName -like "ECCE*" } | ForEach-Object { Say "uninstall entry: ${h}:\$k\$($_.PSChildName) $($_.DisplayName)" } } }
 $arp = Get-ItemProperty "HKCU:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*" -ErrorAction SilentlyContinue | Where-Object { $_.DisplayName -eq "ECCE" }
 Check ($null -ne $arp) "Apps & Features entry in HKCU (per user)"
 Check (-not (Get-ItemProperty "HKLM:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*" -ErrorAction SilentlyContinue | Where-Object { $_.DisplayName -eq "ECCE" })) "no HKLM entry"
@@ -48,7 +50,7 @@ foreach ($c in "complete", "cancel") {
 $env:Path = $sys
 tests\windows\ci-run.ps1 -Stage $stage -Out "$Out\apps"
 Get-Content "$Out\apps\summary.txt" | ForEach-Object { Say "apps: $_" }
-Check (-not (Select-String -Path "$Out\apps\summary.txt" -Pattern "exited rc|missing|FAILED" -Quiet)) "start test summary has no app exited, missing or failed"
+Check (-not (Select-String -Path "$Out\apps\summary.txt" -Pattern "exited rc=-?[1-9]|missing|FAILED" -Quiet)) "start test summary has no app exited, missing or failed"
 
 # The shortcut's own path: wscript + ecce.vbs + ecce.cmd, no console window.
 Start-Process "$env:SystemRoot\System32\wscript.exe" -ArgumentList "//B //Nologo `"$inst\ecce.vbs`""