Repository navigation
Commit 0890f81
ai.nwchem: remove a die() that broke input generation for ordinary jobs
Reported from a live session: NWChem calculations could not be saved --
"Input files could not be generated -- input parsing command
/opt/ecce/scripts/parsers/ai.nwchem ... failed". Gaussian was fine.
sub CCThresh died when CC.ConvergenceEnergy.Value was zero or absent.
nwch.tpl carries ##CCThresh## whatever the theory is, so any job with
no coupled-cluster settings reached it -- including a plain SCF energy,
which is about the most common NWChem job there is.
The die also contradicted the three lines directly beneath it, which
already handle an absent threshold by emitting nothing.
It did no visible harm while the template engine swallowed die()s: the
tag's line silently vanished and generation carried on with a quietly
incomplete deck. a6d0512 (#92) made those errors real, which turned a
silent wrong answer into a hard failure. That is the fix working as
intended -- CLAUDE.md predicted it would "surface errors that were
previously invisible" -- but this particular error was never worth
raising.
Confirmed NOT a regression from this session's changes: the version of
ai.nwchem from before any of them fails identically (exit 255, same
message), so the die is what is wrong. Water/STO-3G/RHF now generates a
valid deck and exits 0.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFMUNbw2UpRPmgsqviAowb1 parent 6ba0486 commit 0890f81
1 file changed
Lines changed: 14 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
953 | 953 | | |
954 | 954 | | |
955 | 955 | | |
956 | | - | |
957 | | - | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
958 | 970 | | |
959 | 971 | | |
960 | 972 | | |
| |||
0 commit comments