Organizer: offer Upload File only inside a calculation (#97)

Upload was offered for any expandable node, so it appeared on projects
and on the server root as well as on jobs -- where it reads like a
general-purpose file manager action and nobody could say what it was
for. Reported from a live session: "The File/Upload File is not clear
in terms of what it is supposed to be used for ... Could be in Tools",
then clarified: it should appear only when you are in a job.

Now gated on the selected node being a calculation. Download is
unchanged -- still offered for anything that is not a collection, i.e.
an actual file -- and a project or the server root now gets neither,
which is the point.

Null-guarded: getResource() can legitimately return 0 on a node whose
resource failed to load, a shape this file has been bitten by before.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFMUNbw2UpRPmgsqviAowb

Author: andy

src/apps/organizer/CalcMgr.C

@@ -2370,13 +2370,34 @@ void CalcMgr::getFileMenu(wxMenu & menu, WxResourceTreeItemData * itemData)
     // (The import entry used to be added here, gated on the selected node
     // being a "project". It is now added unconditionally below -- see there.)
 
+    // Upload only makes sense inside a calculation -- putting a file into a
+    // job's own directory. It used to be offered for ANY expandable node,
+    // so it also appeared on projects and on the server root, where it
+    // reads like a general-purpose file manager action and nobody could say
+    // what it was for. Reported from a live session 2026-09-22.
+    //
+    // Download is unchanged: it is offered for anything that is not a
+    // collection, i.e. an actual file.
     bool isCollection = p_treeCtrl->setExpandable(itemData);
-    wxMenuItem * tmpMenuItem = new wxMenuItem(&menu,
-            isCollection ? wxID_UPLOAD : wxID_DOWNLOAD,
-            _(isCollection ? "&Upload File..." : "&Download File..."),
-            _T(""), wxITEM_NORMAL);
-    //  tmpMenuItem->SetBitmap(ewxBitmap(isCollection?"upload.xpm":"download.xpm"));
-    menu.Append(tmpMenuItem);
+    bool isCalculation = false;
+    Resource *menuRes = itemData->getResource();
+    if (menuRes != (Resource*)0) {
+      isCalculation = (menuRes->getContentType() ==
+                       ResourceDescriptor::CT_CALCULATION);
+    }
+
+    wxMenuItem * tmpMenuItem = (wxMenuItem*)0;
+    if (isCollection && isCalculation) {
+      tmpMenuItem = new wxMenuItem(&menu, wxID_UPLOAD, _("&Upload File..."),
+                                   _T(""), wxITEM_NORMAL);
+    } else if (!isCollection) {
+      tmpMenuItem = new wxMenuItem(&menu, wxID_DOWNLOAD,
+                                   _("&Download File..."),
+                                   _T(""), wxITEM_NORMAL);
+    }
+    if (tmpMenuItem != (wxMenuItem*)0) {
+      menu.Append(tmpMenuItem);
+    }
 
     menu.AppendSeparator();
   }