Skip to content

Commit 8f2a64c

Browse files
authored
ci: pass shared workflows only the secrets they read (#442)
1 parent 1aecb59 commit 8f2a64c

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,5 @@ jobs:
2828
uses: FerrLabs/.github/.github/workflows/reusable-ferrflow-release.yml@b6a08e6055076c18cfa7b8f80c9925275ed407fe # main
2929
with:
3030
dry-run: ${{ inputs.dry_run || false }}
31-
secrets: inherit
31+
secrets:
32+
TAG_SIGNING_KEY: ${{ secrets.TAG_SIGNING_KEY }}

‎.github/workflows/scorecard.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ jobs:
4545
retention-days: 5
4646

4747
- name: Upload to code scanning
48-
uses: github/codeql-action/upload-sarif@b96794f015dfd88f77b49b1c93e0fa7110f94c63 # v4
48+
uses: github/codeql-action/upload-sarif@b96794f015dfd88f77b49b1c93e0fa7110f94c63 # v4.38.0
4949
with:
5050
sarif_file: results.sarif

‎.github/workflows/security-scan.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,3 @@ jobs:
2020
contents: read
2121
security-events: write
2222
uses: FerrLabs/.github/.github/workflows/reusable-security-scan.yml@b6a08e6055076c18cfa7b8f80c9925275ed407fe # main
23-
secrets: inherit

‎.github/workflows/sonarqube.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
key: ${{ runner.os }}-cargo-cov-${{ hashFiles('Cargo.lock') }}
6262
restore-keys: ${{ runner.os }}-cargo-cov-
6363

64-
- uses: taiki-e/install-action@67729d5c413db75907f0ad1e39bb04b9c868ff60 # v2
64+
- uses: taiki-e/install-action@67729d5c413db75907f0ad1e39bb04b9c868ff60 # v2.85.7
6565
with:
6666
tool: cargo-llvm-cov
6767

@@ -139,4 +139,5 @@ jobs:
139139
-Dsonar.coverage.exclusions=site/**
140140
-Dsonar.tests=.
141141
-Dsonar.test.inclusions=**/tests.rs,**/tests/**
142-
secrets: inherit
142+
secrets:
143+
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

0 commit comments

Comments
 (0)