Repository navigation
Replies: 5 comments 4 replies
|
Small follow-up, since you liked my message on Discord I'm taking that as a maybe :) Here's roughly what I have in mind, so you can say no before I write much code. First the four watch PRs I already opened (#791, #789, #790, #783). They're small fixes and don't depend on the redesign. They're stuck on action_required because I'm a first-time contributor, so they need you to approve the CI runs. Then the redesign, one screen per PR, each one branched from main and built on SessionStore, WatchCore and the current snapshot/event sync. The look stays openGym's: the colours from index.css, the user's accent on the main button, SF fonts, nothing from my old app's branding. What changes is the layout and how it works. One session screen with Overview, Set and Metrics side by side like Apple's Workout app. Rest shows under the set instead of replacing the whole screen. The crown edits weight or reps after you tap the box, with a keypad for odd numbers. You can reopen or undo a logged set, and finishing is a hold so it can't happen by accident. Holds, sides, the weigh-in, the clips and the complications stay as they are. Every PR gets WatchCore tests, strings in all the languages and screenshots from the iOS CI demo mode, since you said you can't test iOS yet. I test everything on my own iPhone and watch before opening it. The first one is small: sending the accent colour to the watch (right now it's always green there), with a stricter contrast check because the watch background is black. A few things I'd like your opinion on before I get there:
I'll post side by side screenshots of the main screens in the next few days so you can see what I mean. |
|
Yes please! Post the side by side screenshots here first, then one screen per PR on top of SessionStore, like you suggested. A few guardrails so reviews stay quick: keep the phone/watch message format as it is, strings through ios/ci/watch-strings.mjs, logic in WatchCore with tests, check 41 mm and Always On, and no new exercise media beyond what the watch already gets. Heads-up: your four PRs (#791, #789, #790, #783) are in 1.4.3 now, and 1.4.3 also adds an RPE/RIR disc next to Done, a Lock button and slightly bigger numbers, so please start from release-1.4.3 (or main once 1.4.3 is out). I'll get back to your four questions separately. |
|
The Phase A screens are all up as PRs now (#832–#896), and none of them changes the phone/watch messages. What's left needs your yes, because each one changes the message format you asked me to keep. Could you go through the list and answer per item (yes / no / later)? I'll do them one PR at a time, smallest first, and each PR shows the exact payload change at the top.
Rules I'd keep for all of them: old phones and old watches ignore what they don't know (new fields optional, unknown events dropped), and Two phone-side clean-ups too, since the new watch makes them pointless:
Happy to drop any of these if they don't fit openGym. |
|
Hey! Just saw the Wear OS port landed, and the Garmin simulator rig too. Thanks a lot for the credit 🙏 Here's what I'd do next, Wear OS first since it ships in 1.4.5:
Garmin after that. Since you're in Views.mc right now, how do you want to split it? My idea: I draw the screens first (start, set, rest, overview, metrics, summary, for a buttons-only watch, a touch one and the Venu Sq) and post them here before any code. Any PR that needs a field the Garmin snapshot drops today (accent, crown, effort, autoHolds, weighIn/lastBw) asks you first. Two quick ones:
|
|
Might be nice to look at design of the new Fitness+ Gym strength for some inspiration about layout and styling for the watch app! |

Uh oh!
There was an error while loading. Please reload this page.
Hi! I found openGym very recently and moved over from Hevy. Really happy with it so far.
When I started using the watch app I noticed a few things I think could be better. Mostly because before finding openGym I spent a couple of months building my own iPhone + Apple Watch logger (SwiftUI, also AGPL), so I've been through a lot of the same problems. I've stopped working on it now, but some of its watch screens work better in the gym than the current ones, mainly the in-set screen, editing weight and reps with the crown, and the rest timer.
I don't want to show up with a huge PR nobody asked for, so: would you be interested in this at all? If yes, I'd post some screenshots side by side first, and then do it in small PRs, one screen at a time, on top of the existing SessionStore so the phone/watch sync stays as it is.
No problem if it doesn't fit your plans for the watch app.
All reactions