Repository navigation
Commit e239761
committed
fix(cli): mount the config from an absolute --config path correctly
`cb init` built the config bind-mount source as `./{config_path}`. The prefix
is needed for a relative path, which compose would otherwise read as a named
volume, but an absolute path became `.//abs/path`: compose resolves that
against the project directory, docker creates a root-owned directory there,
and the sidecar starts with a DIRECTORY mounted at /cb-config.toml, dying
with `Unable to find config file: "/cb-config.toml": Is a directory`.
The prefix is now added only when the path needs it. Every other mount in the
generated file already passed its path through unchanged.
The init integration test already ran with an absolute --config but asserted
only the mount's container side, so the bug rendered under it; it now pins the
host side too.1 parent 78e0a46 commit e239761
2 files changed
Lines changed: 35 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
134 | 137 | | |
| 138 | + | |
135 | 139 | | |
136 | | - | |
137 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
138 | 143 | | |
139 | 144 | | |
140 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
34 | 47 | | |
35 | 48 | | |
36 | 49 | | |
| |||
91 | 104 | | |
92 | 105 | | |
93 | 106 | | |
94 | | - | |
95 | | - | |
| 107 | + | |
| 108 | + | |
96 | 109 | | |
97 | 110 | | |
98 | 111 | | |
| |||
954 | 967 | | |
955 | 968 | | |
956 | 969 | | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
957 | 982 | | |
958 | 983 | | |
959 | 984 | | |
| |||
0 commit comments