Merge branch 'sigp-audit-fixes' into update-cbst2-02

Author: jclapis

tests/tests/signer_jwt_auth.rs

@@ -178,43 +178,3 @@ async fn test_signer_only_admin_can_revoke() -> Result<()> {
 
     Ok(())
 }
-
-// Starts the signer moduler server on a separate task and returns its
-// configuration
-/*
-async fn start_server(port: u16) -> Result<StartSignerConfig> {
-    setup_test_env();
-    let chain = Chain::Hoodi;
-
-    // Mock JWT secrets
-    let module_id = ModuleId(JWT_MODULE.to_string());
-    let mut jwts = HashMap::new();
-    jwts.insert(module_id.clone(), JWT_SECRET.to_string());
-
-    // Create a signer config
-    let loader = SignerLoader::ValidatorsDir {
-        keys_path: "data/keystores/keys".into(),
-        secrets_path: "data/keystores/secrets".into(),
-        format: ValidatorKeysFormat::Lighthouse,
-    };
-    let mut config = get_signer_config(loader);
-    config.port = port;
-    config.jwt_auth_fail_limit = 3; // Set a low fail limit for testing
-    config.jwt_auth_fail_timeout_seconds = 3; // Set a short timeout for testing
-    let start_config = get_start_signer_config(config, chain, jwts, ADMIN_SECRET.to_string());
-
-    // Run the Signer
-    let server_handle = tokio::spawn(SigningService::run(start_config.clone()));
-
-    // Make sure the server is running
-    tokio::time::sleep(Duration::from_millis(100)).await;
-    if server_handle.is_finished() {
-        return Err(eyre::eyre!(
-            "Signer service failed to start: {}",
-            server_handle.await.unwrap_err()
-        ));
-    }
-    Ok(start_config)
-}
-
-*/