Repository navigation
fix(service-bus): require exact true to enable emulator administration - #40415
Draft
Eldert Grootenboer (EldertGrootenboer) wants to merge 2 commits into
Draft
Eldert Grootenboer (EldertGrootenboer) wants to merge 2 commits into
Eldert Grootenboer (EldertGrootenboer) wants to merge 2 commits into
Conversation
- Align administration and exported parser with exact-true emulator semantics. - Preserve secure defaults, explicit ports and SAS signing with regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 56e92b5a-ee90-4b51-ac6a-6ccbc18dbdda
Eldert Grootenboer (EldertGrootenboer)
requested a balanced review from Copilot
October 20, 2026 22:23
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Eldert Grootenboer (EldertGrootenboer)
October 20, 2026 22:24
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow fix has focused regression coverage and no identified blocking issues.
1 open issue
What changed in this PR
Fixes Service Bus emulator opt-in so only the parsed lowercase value true enables HTTP administration and sets the exported emulator flag.
Changes:
- Replaces truthiness checks with exact comparisons.
- Adds regression coverage for transport selection, credentials, SAS audience, and parser edge cases.
- Updates package metadata and release notes to 7.10.1.
| File | Description |
|---|---|
sdk/servicebus/service-bus/test/internal/unit/connectionString.spec.ts |
Covers emulator flag parsing edge cases. |
sdk/servicebus/service-bus/test/internal/unit/atomAdminClient.spec.ts |
Tests transport selection and credential protections. |
sdk/servicebus/service-bus/src/util/constants.ts |
Updates runtime version to 7.10.1. |
sdk/servicebus/service-bus/src/util/connectionStringUtils.ts |
Requires exact true for the emulator flag. |
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts |
Requires exact true to enable HTTP. |
sdk/servicebus/service-bus/package.json |
Bumps package version to 7.10.1. |
sdk/servicebus/service-bus/CHANGELOG.md |
Documents corrected opt-in behavior. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 56e92b5a-ee90-4b51-ac6a-6ccbc18dbdda
Eldert Grootenboer (EldertGrootenboer)
requested a balanced review from Copilot
October 20, 2026 23:00
Copilot started reviewing on behalf of
Eldert Grootenboer (EldertGrootenboer)
October 20, 2026 23:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
ServiceBusAdministrationClientenables HTTP forUseDevelopmentEmulator=falsebecause the parsed value is a nonempty string. The exportedparseServiceBusConnectionString()also returnsuseDevelopmentEmulator: true.Fix
Require the exact lowercase value
trueat both sites, matching the existingcore-amqpbehavior. The default HTTPS transport, explicit emulator ports, and credential-overload HTTPS protections are unchanged.Applications relying on another value to enable HTTP must set
UseDevelopmentEmulator=true.Testing
truesupports queue create/read/list/delete and AMQP send/receive/complete;falseand absent flags select HTTPS and fail TLS against the HTTP listener. Explicit port, SAS audience and HMAC signature checks passed.What changed
sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.tssdk/servicebus/service-bus/src/util/connectionStringUtils.tssdk/servicebus/service-bus/test/internal/unit/atomAdminClient.spec.tssdk/servicebus/service-bus/test/internal/unit/connectionString.spec.tssdk/servicebus/service-bus/package.jsonsdk/servicebus/service-bus/src/util/constants.tssdk/servicebus/service-bus/CHANGELOG.md