Question to recent change Records<K, V> to { [key: K]: V }

[Erisli]

Recently, Records<K, V> was changed to { [key: K]: V }. This works well with HashMap<String, T>, but not really well with HashMap<Enum, T>. When I imported this type to my ts, it gave me this error

An index signature parameter type cannot be a literal type or generic type. Consider using a mapped object type instead.

I tried changing it from

type MyType = { [key: MyEnum]: MyStruct } 

To

type MyType = { [key in MyEnum]: MyStruct } 

It works.

I have also tried doing #[ts(type = "...")], but I am having trouble of importing MyStruct and MyEnum automatically.

Is there any suggestion to go around this without manually implementing it? Thank you all for such great work.

[gustavo-shigueo]

Hello @Erisli!

This change was made to allow recursive types when dealing with HashMap. I'll quickly check if changing to a mapped type breaks anything and if not, I'll open a PR

[gustavo-shigueo]

Thanks!

[gustavo-shigueo]

I had to change it so the type will generate as

type MyType = { [key in MyEnum]?: MyStruct }
//                             ^ Note the `?`

Otherwise TS would require ALL variants to be in the object

[Erisli]

Looks good to me!

[gustavo-shigueo]

Done! Check out #339

[Erisli]

Thank you again for such amazing work and project!!!!!