Skip to content

chore: bump version to 0.12.2 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-EION merged 1 commit into from
May 21, 2026
Merged

chore: bump version to 0.12.2 #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ members = [
# embed in `FInstall.txt`'s `maxima_lib_version` field, and
# `maxima-resources` is a build-time helper crate).
[workspace.package]
version = "0.12.1"
version = "0.12.2"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping the workspace version without updating Cargo.lock leads to an out-of-sync state that breaks CI builds using --locked. Additionally, since maxima-lib pins its own version (lines 18-21) for FInstall.txt, its version will remain at 0.12.1 unless explicitly bumped, potentially resulting in incorrect version reporting for the fixes mentioned in the PR description.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the bug fixes for #19 (such as the is_done() logic) are located within the maxima-lib crate, its version should also be incremented. Since maxima-lib opts out of workspace versioning to maintain its own version for the FInstall.txt metadata (as described in lines 18-21), failing to bump it will result in an outdated version being reported by the library despite the workspace-level patch.


[profile.release]
strip = true
Expand Down
2 changes: 1 addition & 1 deletion installer/maxima-setup.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
!define PRODUCT_NAME "Maxima"
!define PRODUCT_PUBLISHER "Armchair Developers"
!define PRODUCT_WEB_SITE "https://github.com/ArmchairDevelopers/Maxima"
!define PRODUCT_VERSION "0.12.1"
!define PRODUCT_VERSION "0.12.2"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is recommended to add version metadata to the installer's resource table using VIProductVersion and VIAddVersionKey. This ensures the version information is correctly displayed in Windows File Explorer properties and other system tools.

!define PRODUCT_VERSION "0.12.2"
VIProductVersion "0.12.2.0"
VIAddVersionKey "ProductName" "${PRODUCT_NAME}"
VIAddVersionKey "ProductVersion" "${PRODUCT_VERSION}"
VIAddVersionKey "FileVersion" "${PRODUCT_VERSION}"
VIAddVersionKey "FileDescription" "${PRODUCT_NAME} Installer"
VIAddVersionKey "LegalCopyright" "${PRODUCT_PUBLISHER}"

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding version metadata to the installer executable. This ensures that the file properties (Right-click -> Details) correctly display the version, product name, and publisher information in Windows Explorer. Note that VIProductVersion requires a four-part version string.

!define PRODUCT_VERSION "0.12.2"
VIProductVersion "${PRODUCT_VERSION}.0"
VIAddVersionKey "FileVersion" "${PRODUCT_VERSION}"
VIAddVersionKey "ProductVersion" "${PRODUCT_VERSION}"
VIAddVersionKey "ProductName" "${PRODUCT_NAME}"
VIAddVersionKey "CompanyName" "${PRODUCT_PUBLISHER}"
VIAddVersionKey "FileDescription" "${PRODUCT_NAME} Installer"

!define PRODUCT_UNINST_KEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}"
!define PRODUCT_UNINST_ROOT_KEY "HKLM"

Expand Down
Loading